[typescript-fetch] Support AWSv4 Signature #15929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes OpenAPITools#12340 Signed-off-by: Jérôme Jutteau <jerome.jutteau@outscale.com>
|
thanks for the PR. cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) |
macjohnny
reviewed
Jul 22, 2023
There was a problem hiding this comment.
I think it would be better to avoid vendor-specific code, and rather leverage the Middleware mechanism (
@TiFu wdyt?
| {{/bodyParam}} | ||
| const signer = new runtime.AwsV4Signer(this.configuration.awsV4SignerParameters); | ||
| const signResult = await signer.sign('{{httpMethod}}', SignUrl, headerParameters, SignBody); | ||
| //request.url = signResult.url; |
There was a problem hiding this comment.
Suggested change
| //request.url = signResult.url; |
| const signer = new runtime.AwsV4Signer(this.configuration.awsV4SignerParameters); | ||
| const signResult = await signer.sign('{{httpMethod}}', SignUrl, headerParameters, SignBody); | ||
| //request.url = signResult.url; | ||
| //request.method = signResult.method; |
There was a problem hiding this comment.
Suggested change
| //request.method = signResult.method; |
| {{^withoutRuntimeChecks}} | ||
| body: {{dataType}}ToJSON(requestParameters.{{paramName}}), | ||
| const SignBody = JSON.stringify(request.body); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12340
This PR propose to implement AWSv4 authentication method for typescript-fetch generator.
It has been used in https://github.com/outscale/osc-sdk-js project.
cc @leonyu.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)